jonhoo / jonhoo/bus

Async review

Open
#22 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
846
Forks
43
PR merge metrics
No merged PRs in 30d

Description

Hi, since I need this crate for a project I'm working on, I decided to give implementing futures `Stream` for a BusReceiver (Bus sending isn't async in this patch), however I am curious as to whether this implementation is correct, since I'm not too experienced with lock-free code

[lib.rs](https://github.com/SethDusek/bus/blob/master/src/lib.rs#L597)

Basically, if a value is not ready, it sends the current Waker (kind of equivalent of thread handle) to the unparking channel, which will wake it up when it's ready.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.