jonathanKingston / jonathanKingston/wurst

Option return for HtmlElement

Open
#20 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
8
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Annoyingly ident returns https://github.com/jonathanKingston/wurst/blob/501e8266b8836abb74614dc792c5f7e72141ca94/build/codegen.rs#L273 have to return an Option as we aren't able to return a real result.

The real problem is that the following code returns an option: https://github.com/jonathanKingston/wurst/blob/501e8266b8836abb74614dc792c5f7e72141ca94/build/codegen.rs#L288

Perhaps the code could create and hold ownership of multiple dyn references at create element time?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading build/codegen.rs at the referenced lines 273 and 288, focusing on how HtmlElement and the optional result are generated. Clarify the ownership and return-value requirements before choosing an approach. Done should ensure HtmlElement generation handles the optional result without requiring an invalid concrete return.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, wasm
Domain
build-system, web-dev
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.