jonataslaw / jonataslaw/VideoCompress

I think that the package should have consistent typing to represent duration in milliseconds to avoid conversion

Open
#273 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
262
Forks
344
PR merge metrics
No merged PRs in 30d

Description

`MediaInfo.duration` is type `double?` and represent milliseconds
`Future getFileThumbnail` has a parameter `position` of type `int` that represents a position in milliseconds

I think that the package should have consistent typing to represent duration in milliseconds to avoid conversion

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.