jonataslaw / jonataslaw/VideoCompress

wrong video width and height

Open
#172 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
Swift
Stars
262
Forks
344
PR merge metrics
No merged PRs in 30d

Description

i had a issue which video width and height was wrong on android
After looking on code i noticed this

https://github.com/jonataslaw/VideoCompress/blob/e51b3eb0f357f5e478e1fd4e51a87219155ed178/android/src/main/kotlin/com/example/video_compress/Utility.kt#L14

should be
``` kotlin
fun isLandscapeImage(orientation: Int) = orientation == 90 || orientation == 270
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.