jonataslaw / jonataslaw/VideoCompress

cancelCompression is not working

Open
#164 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
262
Forks
344
PR merge metrics
No merged PRs in 30d

Description

When I call VideoCompress.cancelCompression() my progress stream stops receiving new values, but VideoCompress.compressVideo() doesn't return anything. Seems like compressing is still in progress cuz after some time compressVideo() will return MediaInfo with compressed file (and with isCanceled = true).
I even tried to use `CancelableOperation.fromFuture(VideoCompress.compressVideo())` and it works for me, but then I noticed that if I will select the next video to compress right after cancelation, then the compression progress stream shows 0. And after some time (seems like it waits for the previous compression to complete even if I canceled it) stream will produce valid progress values.

So, please, take a look at the cancel method. I've tested on iPhone 12 with iOS 15.2.1.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.