jolicode / jolicode/elastically

DocumentExchangerInterface should also allow fetching multiple documents at once

Open
#55 0 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue v2.0
Dominant language
PHP
Stars
257
Forks
43
Avg merge
38m
Merged PRs (30d)
1

Description

From a performance POV, the current DocumentExchangerInterface is not ideal for the MultipleIndexationRequest use-case.

It can only fetch one document at a time, so it perform 1 SQL request (if SQL is used) for each IndexationRequest instead of possibly one for the whole MultipleIndexationRequest.

Would be nice to add `DocumentExchangerInterface::fetchDocuments` and use it when appropriate.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.