jolicode / jolicode/elastically

Remove deprecated code and Factory in favor of full DI

Open
#115 8 comments 1 reaction 0 assignees View on GitHub
enhancement Hacktoberfest v2.0
Dominant language
PHP
Stars
257
Forks
43
Avg merge
38m
Merged PRs (30d)
1

Description

Dependency Injection should be the only way to deal with all our services.

For 2.0, let's get rid of all the error prone code and have only one way to use the lib - removing the Factory.

- Mapping providers should not need a context
- Mapping directory should be set in the Mapping Provider only, right now it's also needed in the Client
- https://github.com/jolicode/elastically/pull/120#issuecomment-1272987345

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.