joke2k / joke2k/faker

German IBAN incorrect checksum

Open
#2,448 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
19.4k
Forks
2.1k
PR merge metrics
No merged PRs in 30d

Description

Hi there!

Thanks for this awesome library!

It looks like the German IBAN provider generates invalid IBANs right now. For example, we generated `DE06770332760657893171` using the German IBAN provider, which is invalid according to both https://de.iban.com/iban-checker and https://www.ibancalculator.com/

Not sure if this is a regression, we only recently started using faker.

Let me know if you need any more information!

Thanks!

Contributor guide

Open the contributing guide

Research direction

Locate the German IBAN provider and its existing tests, then reproduce the example IBAN DE06770332760657893171. Trace how the provider generates its checksum and add a regression test covering a valid German IBAN. Done means generated German IBANs pass the reported checksum validators and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
payments
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.