joist-orm / joist-orm/joist-orm

Test `superstruct` against current major version

Open
#1,300 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
385
Forks
26
Avg merge
8h 55m
Merged PRs (30d)
42

Description

Today, the test suite runs against `superstruct` `0.15.x`:

![Screenshot 2024-11-20 at 11-29-39 Code search results](https://github.com/user-attachments/assets/7b8194d5-e86e-473d-9798-89ce83ac5d5b)

However, the current major version is `2.x`. It would be nice to test against the current major version so people could be confident in updating.

Further, it's probably a good idea for `joist`'s `package.json` to specify `superstruct` as an optional peer dependency, with the supported version(s). You can use the `peerDependenciesMeta` option to specify optional peerdeps.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.