johno / johno/rework-flex-grid

Incorrect column size

Open
#4 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
19
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Hey,

I noticed a possible issue with the small column widths. I've got 2 columns each at 50% for all 3 screen sizes (`.grid-row-col-6-12--{sm/md/lg}`). There's a title on the left and a button on the right. When collapsed to < 32rem (512px I think), they both stay at 100% width. Where as they should stay at 50% each.

Here's a [gist](https://gist.github.com/eliquious/a1401f4fa9d4702135a6).

The md and lg sizes work fine. It seems to be the `flex-basis: 100%` rule causing the issue. Any ideas?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.