johno / johno/pixyll

$base_font_size is overriden in _media-queries.scss

Open
#264 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
SCSS
Stars
2.1k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Similarly to https://github.com/johnotander/pixyll/issues/196 - there's a variable in `_variables.scss` for `$base_font_size` (14px by default), but this is overriden in `_media-queries.scss`:

``` sass
@media screen and (min-width: $viewport-large) {
html {
font-size: 20px;
}
}
```

I'm guessing this should be expressed in terms of the `$base_font_size` - e.g 1.5rem for simplicity (21px) or 1.4286rem for exactness (20.0004px)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.