johno / johno/ember-cli-dates

Locale is made global

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
17
Forks
13
PR merge metrics
No merged PRs in 30d

Description

As a result of recent changes with moment.js, when a locale is declared, it is made global. Since, in this context, it isn't desirable, we should expose the ability to set a default locale for the app:

``` js
return moment().locale(app.env.defaultDatesLocale || 'en');
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.