joeroe / joeroe/era

Conversion between eras with NA units

Open
#29 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
R
Stars
15
Forks
0
PR merge metrics
No merged PRs in 30d

Description

`yr_transform()` currently throws an error if either the source or destination era has an NA unit, following the R convention that `NA == NA` is NA.

It might not be necessary to be this strict, for example to allow transformations between era("bp") and era("bce"), and just warn that there is an assumption that the units are comparable.

Contributor guide

Open the contributing guide

Research direction

Start with yr_transform() and inspect its current handling of source and destination eras with NA units. Define the expected conversion and warning behavior for cases such as era("bp") and era("bce"); the work is done when those cases and existing conversions have clear tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.