cal summary functions ignore era
Open
- Dominant language
- R
- Stars
- 10
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
`min.cal` and `max.cal` both assume that the object passed to them uses BP-like years, i.e. min returns `max(year)` and max returns `min(year)`. This is confusing if they're used on dates with a CE-based era or negative BCE/BP years.
These and other functions should take into account the `era` attribute of `cal` objects.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by locating the min.cal and max.cal implementations and inspect how cal objects store and use their era attribute. Check related summary functions for the same assumption; done means summaries handle CE, BCE, and BP or negative years consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100