jodit / jodit/jodit-angular

Error in popup output

Open
#117 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
48
Forks
35
PR merge metrics
No merged PRs in 30d

Description

Angular 13
"jodit": "~3.23.3",
"jodit-angular": "~1.13.6"

When opened, popups end up at the end of the body, which is why color theme tokens are not read. Is there a way to specify a custom container for all popups?

https://i.postimg.cc/qvG1hSFg/2.png

There is also a bug in the buttons for popup "img" setting.

public config = {
    popup: {
          img: [
             { name: 'delete', icon: 'delete' },
             { name: 'nullable' },
             { name: 'nullable' },
             { name: 'left', list: ['left', 'right', 'center', 'justify'] },
          ]
    }
}

This configuration deprives the "Delete" Icons button, it cannot be added there.
Maybe I'm doing something wrong? The task is to remove two unnecessary buttons and replace the icons

(nullable & display:none) the only way I found to remove the buttons

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the popup behavior with Angular 13, jodit ~3.23.3, and jodit-angular ~1.13.6 using the configuration shown in the issue. Investigate how popup placement and the popup.img button configuration are handled; done means establishing whether a custom container can be specified and whether the requested buttons and icons behave correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.