joaorb64 / joaorb64/TournamentStreamHelper
Layouts updating multiple times when changing players
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 139
- Forks
- 59
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 6
Description
When a player's whole data (either by loading a set or swapping players) is changed, layouts try to update multiple times, which cause issues with animations on some layout (most obvious on tournament_history). I haven't been able to investigate the issue further, but I assume one update is made for each field in each player's widget. In that case, this is technically the intended behavior, but I do think we should look for a way to avoid the repeated updates.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing a full player-data change through loading a set or swapping players, then trace how player widgets notify layouts, with tournament_history as the clearest case. Determine why one logical change causes repeated layout updates; done means each change updates layouts without disrupting animations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100