joaorb64 / joaorb64/TournamentStreamHelper

5.802: Assets with no `uncropped_edge` but with `rescaling_factor` can be smaller than the canvas in the thumbnail

Open
#744 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
139
Forks
59
Avg merge
2d 9h
Merged PRs (30d)
6

Description

When using UMVC3 base_files/icon assets v2.01 in the thumbnail generator, Venom and other characters with a smaller than 1 rescaling factor not only appear smaller than they should, but also do not respect the canvas constraint from the lack of uncropped edge

Venom-vs-Akuma-2024-06-30-15-19-58

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the thumbnail generator and reproduce the issue with the UMVC3 base_files/icon assets v2.01, especially Venom and other assets with a rescaling factor below 1. Compare the generated thumbnail size and canvas constraint when uncropped_edge is absent; done means these assets are no longer undersized and respect the canvas constraint.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.