joaorb64 / joaorb64/TournamentStreamHelper
5.751: `character_gallery` layout prioritizes fitting `ssf2x/gba_portraits` over filling the canvas
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 139
- Forks
- 59
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 6
Description
When using the character_gallery layout widget with the ssf2x/gba_portraits assets, using the config below:
{
"assets": {
"default": {
},
"ssf2x": {
"asset_key": "gba_portrait",
"custom_zoom": 1.0
}
}
}
and when setting the character_gallery resolution to a tall one (e.g. 200x700), we can see that the layout prioritizes fitting the whole image, instead of trying to fill the canvas, as would be the baseline for a 1.0 zoom value. (See screenshot)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the character_gallery layout widget and reproduce the tall 200x700 configuration with the ssf2x/gba_portraits assets and custom_zoom set to 1.0. Trace how the layout chooses image scaling, then verify that the result fills the canvas rather than prioritizing fitting the whole image.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100