joaorb64 / joaorb64/TournamentStreamHelper
5.751: Rescaling factor does not seem to apply to either the thumbnail or HTML layouts if there is no uncropped edge
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 139
- Forks
- 59
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 6
Description
Adding the rescaling_factor element to an asset pack’s characters does not seem to affect the actual size of the character on the HTML layouts or the thumbnail generator if the uncropped_edge element is non-existent, signifying a cropped asset pack
Tested with Omega Strikers art, I tried setting Kazan (right) to have a scaling x1000 and it fails, the scaling applied on a 100% zoom on the thumbnail is 0.10 % compared to Drek’ar’s (left) x1.0 and 0.19 % scale
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with the Omega Strikers art asset pack, comparing Kazan and Drek’ar at different rescaling_factor values. Trace how rescaling_factor is handled in the HTML layouts and thumbnail generator when uncropped_edge is absent; done means the scaling affects both outputs for cropped asset packs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100