joaorb64 / joaorb64/TournamentStreamHelper

5.65: Edge of an uncropped edge asset pack does not match the edge of P1 side on a `type_b` thumbnail

Open
#436 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
139
Forks
59
Avg merge
2d 9h
Merged PRs (30d)
6

Description

When selecting the type_b thumbnail template and using assets without any uncropped edges (e.g. sg/full), the edge sometimes will not match the edge of the P1 side when it does. Using the default backgrounds, this results in 1-pixel wide red column appearing in the middle of the image

Example

Marie-vs-Filia-2023-06-11-12-11-41

Used game settings

Screenshot_1326

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the type_b thumbnail template, sg/full assets, and default backgrounds described in the report. Trace the thumbnail-generation entry point to find where the uncropped asset edge is aligned with the P1 side; done means the edges match without a 1-pixel red column.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.