joaorb64 / joaorb64/TournamentStreamHelper

5.2: 4/3 layouts do not use eyesight centering

Open
#263 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
139
Forks
59
Avg merge
2d 9h
Merged PRs (30d)
6

Description

4/3 layouts don't seem to center the character's eyesight to a defined point in the container, I can't find the value for it in the index.js file

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading index.js and locate the 4/3 layout handling and any existing eyesight-centering values. Compare how the character is positioned within the container and determine the defined point the layout should use. Done means 4/3 layouts visibly center the character's eyesight consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.