jmespath / jmespath/jmespath.terminal

explicitly set bg color for every panel

Open
#10 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
478
Forks
65
PR merge metrics
No merged PRs in 30d

Description

There are some themes where the current font colors end up being the same as the default background color. One example is the [Solarized](http://ethanschoonover.com/solarized) "Light" theme for iTerm2 (based on an input of `{ "foo": "bar" }`:

![screen shot 2015-07-24 at 20 10 17](https://cloud.githubusercontent.com/assets/222581/8887661/90f2d1d8-3240-11e5-94a9-f68c2e011f86.png)

Note how the `"foo"` key disappears since it's the same color as the background. Change the theme (in this case to Solarized "Dark"), and it shows up:

![screen shot 2015-07-24 at 20 11 41](https://cloud.githubusercontent.com/assets/222581/8887666/b46dfc64-3240-11e5-8e72-fe8fb992eee8.png)

I don't know that much about xterm color sequences (or ncurses, etc.), but one thought is that if there is any explicitly colored text in a panel, consider also coloring the background of that panel using an explicit color to avoid the "invisible text" effect like the first screenshot above.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.