jmcarp / jmcarp/robobrowser

RoboBrowser is broken with werkzeug upgrade

Open
#93 4 comments 24 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
3.7k
Forks
336
PR merge metrics
No merged PRs in 30d

Description

werkzeug is upgraded to 1.0.0 and RoboBrowser is broken with this change.
```
Traceback (most recent call last):
from robobrowser import RoboBrowser
File "/home/ubuntu/venv/lib/python3.7/site-packages/robobrowser/__init__.py", line 3, in
from .browser import RoboBrowser
File "/home/ubuntu/venv/lib/python3.7/site-packages/robobrowser/browser.py", line 8, in
from werkzeug import cached_property
ImportError: cannot import name 'cached_property' from 'werkzeug' (/home/ubuntu/venv/lib/python3.7/site-packages/werkzeug/__init__.py)
```

It’s because cached_property has to be explicitly imported from werkzeug.utils now
'from werkzeug.utils import cached_property' should be used instead 'from werkzeug import cached_property'

Contributor guide

Open the contributing guide

Research direction

Start at robobrowser/browser.py, where the traceback shows the failing Werkzeug import, and reproduce the import failure with Werkzeug 1.0.0. Done means RoboBrowser imports successfully with that version and the reported ImportError no longer occurs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
web-dev
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.