jmapio / jmapio/jmap

Add support for type filter in push subscription

Open
#222 1 comment 0 reactions 1 assignee View on GitHub

@neilj is already working on this.

Since Jul 6, 2018.

Extension
Dominant language
Makefile
Stars
1.4k
Forks
100
Avg merge
18h 7m
Merged PRs (30d)
2

Description

You can currently register what types you want to receive pushes for. However, this could still result in more pushes, and thus device wakens, then you need. This could be solved by allowing you to associate a filter object (the same as you would pass to /query) with the type in the push subscription. The server would then only send the push if the state of one of the objects changed matched the filter either before (destroyed, updated) or after (created, updated) the change.

The main downside of this is complexity of implementation; I think it would have to be optional and servers can still just always push whenever the type changes. That's OK, because it doesn't affect the client's implementation. It just means the client may get woken up slightly more often than necessary.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.