jlfwong / jlfwong/speedscope

File format: unit=bytes makes startValue/endValue meaningless

Open
#406 2 comments 2 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
6.8k
Forks
320
PR merge metrics
No merged PRs in 30d

Description

When unit=milliseconds, it's clear that it applies to both timestamps (like startValue) and to sample weights.

But when unit=bytes, there's no way to know what startValue/endValue are supposed to mean.

We should consider separate timeUnit and weightUnit fields.

Contributor guide

Open the contributing guide

Research direction

The issue does not name a file or test. Start by tracing how unit, startValue, endValue, and sample weights are represented in the file format; done means reaching a decided approach for separating timeUnit and weightUnit.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
performance
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.