jldbc / jldbc/pybaseball

team_ids source need to be updated

Open
#510 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.7k
Forks
428
PR merge metrics
No merged PRs in 30d

Description

related to #486 and the fix provided in #504 won't work for the athletics as in 2025 and 2026 the correct name is "ATH", not "OAK". if you are iterating and grabbing team data by year. (i.e. assumed you don't know the teams that year).

for instance if you do `schedule_and_record(2025,"OAK"), you will get results, but it is all nans. the data is actually stored with team name "ATH". Now the list provided in #504 does not even show the "ATH" call shown, but to get any data on the athletics for 2025 and 2026, one needs to use "ATH", not "OAK.

Not sure if there is a better way to get the list of names or need to add an exception, but my current work around is for years after 2025 or 2026, to replace "OAK" with "ATH" with the team names.

Contributor guide

Open the contributing guide

Research direction

Start by tracing the team_ids source and the schedule_and_record entry point for year-based team lookup. Check how team names are obtained for 2025 and 2026, including the existing behavior described in #504. Done means Athletics data is returned for those years when the lookup is performed without prior knowledge of the yearly team name.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
56/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.