jldbc / jldbc/pybaseball

playerid_reverse_lookup does not return 2023 rookies when using fangraphs key type

Open
#360 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.7k
Forks
428
PR merge metrics
No merged PRs in 30d

Description

This is my process

```
# returns 2023 season stats (dataframe includes the rookies when inspected)
fg = pb.fg_batting_data(2023, qual=0)

# create lookup table for all players in 2023
lookup = pb.playerid_reverse_lookup(fg['IDfg'], key_type='fangraphs')

# sort values by descending mlbam keys to show most recently called up players
lookup.sort_values(by=['key_mlbam'], ascending=False)
```

![image](https://github.com/jldbc/pybaseball/assets/64506503/87002565-f0ec-400d-8775-ba9fef7a6c29)
As shown in the image the players at the top are those who were called up late in the 2022 season. No 2023 debuting players are in the lookup table. I am using pybaseball version 2.2.5

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.