jldbc / jldbc/pybaseball

team_pitching function cannot get relief pitching stats

Open
#275 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.7k
Forks
428
PR merge metrics
No merged PRs in 30d

Description

Hey!
I was needing to get access to fan graphs team relief pitching sheet through your package but it just was not letting me.

I looked into it and created my own temporary fix on my install.

In order to get into the relief pitching section, you need to give this parameter in your request payload:
?stats=REL

The issue is in fangraphs.py under "def fetch"
there isnt a good way to insert custom requests for the "stats" parameter in url_options.

In order to get the relief pitching, it needs to have `'stats': 'REL'` but the closest thing you can do is make the parameter stats_columns in the fetch parameters 'REL' but then it rejects that input through some enum

I am not gonna look too much into it, I just deleted the code that was giving the error and made a way to insert 'REL' optionally through an extra parameter in fetch

Here is the fangraphs page I was attempting to fetch
[fangraphs.com](https://www.fangraphs.com/leaders.aspx?pos=all&stats=rel&lg=all&qual=0&type=c,4,5,11,7,8,13,-1,36,37,40,43,44,48,51,-1,240,-1,6,332,45,62,-1,59,-1,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,144,145,146,147,148,149,150,151,152,153,154,155,156,157,158,159,160,161,162,163,164,165,166,167,168,169,170,171,172,173,174,175,176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191,192,193,194,195,196,197,198,199,200,201,202,203,204,205,206,207,208,209,210,211,212,213,214,215,216,217,218,219,220,221,222,223,224,225,226,227,228,229,230,231,232,233,234,235,236,237,238,239,240,241,242,243,244,245,246,247,248,249,250,251,252,253,254,255,256,257,258,259,260,261,262,263,264,265,266,267,268,269,270,271,272,273,274,275,276,277,278,279,280,281,282,283,284,285,286,287,288,289,290,291,292,293,294,295,296,297,298,299,300,301,302,303,304,305,306,307,308,309,310,311,312,313,314,315,316,317,318,319,320,321,322,323,324,325,326,327,328,329,330,331,332&season=2022&month=0&season1=2022&ind=0&team=0,ts&rost=0&age=0&filter=&players=0&startdate=2022-01-01&enddate=2022-12-31)

If anyone could show me what I am doing wrong OR confirm this is an issue as I see, please lmk

Thanks yall for the best!

![image](https://user-images.githubusercontent.com/76456534/172698777-aa1adf55-6c31-4eb8-9945-2086c9dd3b80.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.