jinja2cpp / jinja2cpp/Jinja2Cpp

Missing file error on 'make install'

Open
#260 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
600
Forks
114
PR merge metrics
No merged PRs in 30d

Description

I use internal deps, and ```make install``` fails due to some missing files in ```thirdparty``` (with version 1.3.2, dependencies are no more in submodules).

I had to apply the following patch.

I'm not used enough to cmake to know if there are variables that could be used to get the src dir of the fetched dependencies.

```diff
diff --git a/thirdparty/internal_deps.cmake b/thirdparty/internal_deps.cmake
index 44f0446..0976c8c 100644
--- a/thirdparty/internal_deps.cmake
+++ b/thirdparty/internal_deps.cmake
@@ -75,10 +75,10 @@ if (JINJA2CPP_BUILD_TESTS)
endif()

install (FILES
- thirdparty/nonstd/expected-lite/include/nonstd/expected.hpp
- thirdparty/nonstd/variant-lite/include/nonstd/variant.hpp
- thirdparty/nonstd/optional-lite/include/nonstd/optional.hpp
- thirdparty/nonstd/string-view-lite/include/nonstd/string_view.hpp
+ ${FETCHCONTENT_BASE_DIR}/expected-lite-src/include/nonstd/expected.hpp
+ ${FETCHCONTENT_BASE_DIR}/variant-lite-src/include/nonstd/variant.hpp
+ ${FETCHCONTENT_BASE_DIR}/optional-lite-src/include/nonstd/optional.hpp
+ ${FETCHCONTENT_BASE_DIR}/string-view-lite-src/include/nonstd/string_view.hpp
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/nonstd)

install (TARGETS RapidJson

```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.