jina-ai / jina-ai/executors

Clean up Faiss, purge `jina_commons`

Open
#283 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
31
Forks
12
PR merge metrics
No merged PRs in 30d

Description

Faiss should be cleaned up - the whole rationale behind having the complicated dumping setup is that `faiss.write_index` does not save indexed vectors - which is not true (was it even checked?). So we can simplify FaissSearcher by cutting out significant portions of current code, and getting rid of `jina_commons` dependency, which does not serve any purpose anymore

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.