jina-ai / jina-ai/executor-simpleindexer

Passing non-related arguments breaks the codes

Open
#22 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
13
Forks
2
PR merge metrics
No merged PRs in 30d

Description

https://github.com/jina-ai/executor-simpleindexer/blob/3a5017b4c71c09fc6209aa04412815f1f1896a16/executor.py#L59

This line requires all the parameters must be acceptable by `.match()`, which does not hold in general.

```
f = Flow().add(uses='jinahub://SimpleIndexer')
with f:
f.post(on='/search', parameters={'foo': 1})
```

`.match()` does not accept unknown arguments,

https://github.com/jina-ai/jina/blob/d887c9ed3195884df03e5db754d9ee450dce2e20/jina/types/arrays/neural_ops.py#L17

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.