ji-devs / ji-devs/ji-cloud

Dealing with long sound files in the generators

Open
#3,968 1 comment 0 reactions 1 assignee View on GitHub

@MendyBerger is already working on this.

Since Jun 28, 2023.

Activity: Drag & drop Activity: Flashcards Activity: Matching Activity: Memory game
Dominant language
Rust
Stars
14
Forks
18
PR merge metrics
No merged PRs in 30d

Description

We received a complaint from a user about her long sounds on each card not working well. She had recorded a whole story for each illustration, resulting in overlapping sounds, etc.

(Eliezer V’Hagezer: https://jigzi.org/asset/play/jig/9e0d783c-0ece-11ee-8585-83f35525bbc5?direction=ltr&display_score=false&track_assessments=false&drag_assist=false&is_student=false&draft_or_live=live )

Solutions:

  • In general - sounds should NEVER overlap. Playing one sound should cut off a previous sound that is playing
  • Matching: Play the sound if click or start dragging a card. Sound should not overlap! If click and sound starts playing, then start dragging, and sound starts again, the first sound should stop playing.
  • Flashcards: Flip the card only AFTER the audio is finished. If there is no audio, or the audio is short and finishes before the current time set, then wait until the time limit.
  • Memory game: Flip the card only AFTER the audio is finished. If there is no audio, or the audio is short and finishes before the current time set, then wait until the time limit.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.