ji-devs / ji-devs/ji-cloud

Video in ProDev course player - cut off - need to resize

Open
#3,953 0 comments 0 reactions 1 assignee View on GitHub

@RickyLB is already working on this.

Since Jun 26, 2023.

ProDev Courses
Dominant language
Rust
Stars
14
Forks
18
PR merge metrics
No merged PRs in 30d

Description

You have fixed the aspect ratio of the video player in the ProDev courses really nicely. However, when you open the video on a screen that is wider rather then higher, the video gets cut off along the bottom.
Please resize, keeping the aspect ratio, so that it fits onto the screen.

See the video player below - the bottom of the video is cut off. should rather fit according to the height of the screen.

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.