ji-devs / ji-devs/ji-cloud

Drag and drop: incorrect sound logic

Open
#3,265 1 comment 0 reactions 1 assignee View on GitHub

@johnnynotsolucky is already working on this.

Since Oct 14, 2022.

Activity: Drag & drop Jan23
Dominant language
Rust
Stars
14
Forks
18
PR merge metrics
No merged PRs in 30d

Description

In the current drag & drop state, the incorrect sound plays either when the user drags and drops the item in the wrong area or when simply clicking on the item. If audio is attached to the item, and the item is being clicked, the incorrect sound will play first, followed by the recorded audio, which becomes confusing because of the flow (when dragging and dropping an item, audio is played during the dragging and incorrect/ correct sounds plays when item is dropped). I think it would make more sense if the incorrect sound plays when the item is dragged and dropped in the wrong place, but not when the item is clicked. 
@corinnewo

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.