Use configured JIG settings when playing a JIG
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 14
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Description
[Updated by @johnnynotsolucky]
We need to use the JIG's default settings when a JIG is shared and played. Currently the settings for a JIG only apply for previews. However, when sharing a link/embed/etc, the link includes the player options which are used by the JIG player.
My suggestion is that we use the settings for a JIG when playing, and keep the ability to override those settings when a JIG is played (even if there is no UI to do so).
JigPlayerOptions can be updated to:
pub struct JigPlayerOptions {
pub direction: Option<TextDirection>,
pub display_score: Option<bool>,
pub track_assessments: Option<bool>,
pub drag_assist: Option<bool>,
pub is_student: bool,
pub draft: bool,
}
When a JIG is loaded, if any of the optional fields in JigPlayerOptions is set, then we can override the default config of the JIG with the provided values. By default, nothing would be set and share links should no longer include ?direction=&display_score= etc.
Note: The direction parameter is no longer considered as of #2742 as a stop-gap solution until the above is addressed.
Original issue content
It has come to our attention from a teacher:
If you share a game, the parameters include the LTR or RTL direction.
If the teacher then goes in and republishes it with a different direction, the students don't get this update.
This is a flaw in the logic of our sharing mechanism - it should share the most updated version of the JIG, including if the direction has changed.
Is there anything we can do about it? What would be involved?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.