video is_playing handler
@MendyBerger is already working on this.
Since Nov 7, 2021.
- Dominant language
- Rust
- Stars
- 14
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Description
The controller for controlling playback seems to depend on a Mutable, and then imperatively calls the API: https://github.com/ji-devs/ji-cloud/blob/487e6fcd87c9b81aefbb33d27823ea5b2b15a5b7/frontend/apps/crates/components/src/stickers/video/dom.rs#L71
However, at a glance, it seems like this is only reacting to playing being true - it doesn't actually handle pause?
I'm not entirely sure, so if it's working correctly, feel free to close. Otherwise, please add in the handler for changing to the pause state
(side note- I am implementing some youtube playback for the legacy player and using the same element... added a new dispatch event of "ready" when it's all ready, which made initial playback much simpler for me)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.