ji-devs / ji-devs/ji-cloud

Refactor tooltip component

Open
#1,715 0 comments 0 reactions 1 assignee View on GitHub

@MendyBerger is already working on this.

Since Oct 19, 2021.

frontend - functionality help wanted low needs triage
Dominant language
Rust
Stars
14
Forks
18
PR merge metrics
No merged PRs in 30d

Description

Not sure who to assign this to... it might actually make for a good onboarding task... but assining to @MendyBerger for now with the triage label.

The tooltip components (on the rust/dominator side, as opposed to elements) were written a while ago and were kindof a band-aid solution until we had a better overlay system. Additionally, some of the coding conventions are outdated as it was written before we settled on a better style.

These components are not used everywhere.. for example, the header jiggling tooltips are completely on the element side and do not depend on these components. However, the in-module tooltips do.

Off the top of my head, here's a rough checklist of what should be done:

  • rename State to Tooltip (or TooltipState)
  • impl the render methods on the struct, instead of the naked functions
  • struct should accept self: Rc<Self> (note: this is a new styleguide change... will discuss with @MendyBerger )
  • new method to render via OverlayHandle::lifecycle() (must still support current methods, e.g. mixin too)
  • replace everywhere it's used with this new method
  • the OverlayDom layer in card modules probably won`t be needed anymore... if so, get rid of it
  • the Overlay and OverlayExt in all modules probably wont be needed anymore, and it's currently confusing in terms of how that will order with the OverlayContainer` in the abstraction layer. If it's possible, git rid of it (in the Base/modules, not the generic layer)
  • note: the overlay slot in the module pages is still needed and is where the container is rendered to in the generic layer. don't remove that!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.