ji-devs / ji-devs/ji-cloud

Invalid Email error

Open
#1,148 0 comments 0 reactions 2 assignees View on GitHub

@LeahWhalen is already working on this.

Since Oct 8, 2021.

backend feature low
Dominant language
Rust
Stars
14
Forks
18
PR merge metrics
No merged PRs in 30d

Description

hitting Create returns EmptyError in all cases. It would be better to get more defined errors, at least with these variants:

  • InvalidEmail
  • Unknown (everything else)

At a glance this relies on parsing the SendGrid data which is currently logged as:

StatusCode: 400 Bad Request, Body: {"errors":[{"message":"Does not contain a valid address.","field":"personalizations.0.to.0.email","help":"http://sendgrid.com/docs/API_Reference/Web_API_v3/Mail/errors.html#message.personalizations.to"}]}

So marking this as low priority and putting it in the Future milestone (on the frontend we can assume any error is InvalidEmail, once this issue is resolved)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.