jgorset / jgorset/Recorder

Feature request: move recording logic into a separate class

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
37
Forks
7
PR merge metrics
No merged PRs in 30d

Description

I don't know who is written the same `Recording` class but you have the same "illness":
https://github.com/jgorset/Recorder/blob/master/Sources/Recording.swift
Why did you place `CADisplayLink` which belongs to animation into class which works with audio recording. Why not to separate this logic?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.