jgm / jgm/gitit

Display error message when commit fails (due to pre-commit hook)

Open
#567 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
2.3k
Forks
231
PR merge metrics
No merged PRs in 30d

Description

If a pre-commit hook is used, edits on the website may fail. When this is the case, the page simply doesn't update on “Save”, but it is not made clear to the person who tried to edit the page. Could gitit check the return code of the commit action (I'm not sure exactly how gitit performs the commit)

Ideally, the output of the pre-commit hook should be displayed (if any) along with a failure notice (if the exit code is not 0). Alternatively, a simple, generic error message would already be useful.

Should I look into adding this feature? Would that better be handled as a plugin? (Would a plugin have access to all the same info as a git hook?)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.