jgm / jgm/gitit

max-page-size does not work properly?

Open
#343 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
2.3k
Forks
231
PR merge metrics
No merged PRs in 30d

Description

Seems like `max-page-size` is not working properly even when set to 100K (default): if you save a page with more that 100K characters, gitit should show somewhat like "Server error: Page exceeds maximum size.", instead, it just does not apply any change to the page, and shows you the last page revision before the edit. Actually, that happens not just above 100K bytes, but this problem arises somewhere about 95K bytes — gitit just forgets the changes to the page and does not show any error.

I also tried setting `max-page-size` to 50K, and it works fine, if I insert less than 50K text, it saves, if I insert 60K text, it shows error. However, if I insert, for example, 100K text, it just forgets the changes.

My gitit version is 0.10.1.2, I also built 0.10.2 and reproduced the same bug. I tried to reproduce it on gitit.net, but it works as expected (unfortunately, I don't know the version of gitit installed there).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.