Example restrict-overwrite exemplifies failing unsafe
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 17
- Forks
- 16
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 3
Description
I noted that the error handling in restrict-overwrite example seems unsuitable for production use:
On an occasion where the AQL query were to fail, the error is spuriously silenced, and code proceeds with return { status: UploadStatus.UPLOAD_PROCEED };
The expected behavior would to be fail safely, that is, the error should lead to upload being stopped.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open samples/artifactory/BEFORE_UPLOAD/restrict-overwrite/worker.ts at the linked line and trace the AQL query error path. Done means an AQL failure stops the upload instead of returning UploadStatus.UPLOAD_PROCEED.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100