Unwanted config created if oidc-provider-name is set empty
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 266
- Forks
- 110
- Avg merge
- 3d 15h
- Merged PRs (30d)
- 3
Description
Describe the bug
When the action is called with an empty value set in oidc-provider-name, it creates a dummy config.
- name: Setup JFrog
uses: jfrog/setup-jfrog-cli@ff5cb544114ffc152db9cea1cd3d5978d5074946
env:
JF_ENV_1: ${{ steps.check-token.outputs.jf-env-1 }}
JF_URL: "https://xyz.jfrog.io"
with:
oidc-provider-name: ${{ inputs.oidc-provider-name }}
Current behavior
Action creates an unwanted config when supplied with an empty oidc-provider-name input
Reproduction steps
No response
Expected behavior
Action should ignore creating a config if an empty value is provided in oidc-provider-name input
Setup JFrog CLI version
4.5.11
JFrog CLI version
2.77.0
Workflow operating system type and version
ubuntu-latest
JFrog Artifactory version (if relevant)
No response
JFrog Xray version (if relevant)
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by running the supplied GitHub Actions workflow with an empty oidc-provider-name on ubuntu-latest, then trace the action's handling of that input in the TypeScript source. Done means an empty value no longer creates a config while the JFrog CLI setup still works for a non-empty provider name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, typescript
- Domain
- authentication, ci-cd
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100