JFrog worker deploy command does not support properties
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 595
- Forks
- 307
- Avg merge
- 4d 17h
- Merged PRs (30d)
- 17
Description
Describe the bug
The ability to specify properties for a JFrog worker was added to JFrog, but the JFrog worker deploy command does not support deploying properties as part of the manifest.json.
Current behavior
Using the following command with a manifest.json with properties specified in it (using the same key value format as secrets) results in a successful deployment but the deployed worker will not have the properties set after the deploy:
- jf worker deploy
Reproduction steps
No response
Expected behavior
The JFrog worker deploy command should support deploying properties as part of the manifest.json.
The code related to setting properties from the manifest.json found on this should be updated:
https://github.com/jfrog/jfrog-cli-platform-services/blob/8f25bf2fd1987c0cd4e4faec8eedc71dc64b0909/commands/deploy_cmd.go#L246
JFrog CLI version
2.125.0
Operating system type and version
Windows
JFrog Artifactory version
No response
JFrog Xray version
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in commands/deploy_cmd.go around line 246, where properties from manifest.json are handled for the JFrog worker deploy command. Compare the properties handling with the existing secrets handling and verify that a manifest containing properties deploys them successfully with jf worker deploy.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 82/100