jfrog / jfrog/jfrog-cli-security

Sarif file missing results after 2.78.0 update

Open
#578 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
13
Forks
50
Avg merge
3d 48m
Merged PRs (30d)
26

Description

Describe the bug

When upgrading the JF CLI from 2.77.0 -> 2.78.0, the sarif file produced from jf audit --sast --format=sarif > jfrog_sast.sarif on a dotnet project, doesn't include the results and is deemed misformated by GitHub during the github/codeql-action/upload-sarif@v3 action.

Current behavior

JF CLI v2.77.0(Working)
{"level":"info","msg":"scanner output: \n 2025-08-05 03:05:21 [info ] Starting scan\n2025-08-05 03:05:21 [info ] Handshake successful\n2025-08-05 03:05:21 [info ] Processing codebase\n2025-08-05 03:05:23 [info ] Side effects only import. No values imported.\n2025-08-05 03:05:23 [info ] Generated IR for 117 files in 1.61 seconds.\n2025-08-05 03:05:25 [info ] Loaded: 117 files with 8,886 lines of code and 893 functions in 3.87s\n2025-08-05 03:05:25 [info ] Running 50 rules\n2025-08-05 03:05:26 [info ] Located 0 findings in 0.61s\n2025-08-05 03:05:26 [info ] Analysis took 0.61s\n2025-08-05 03:05:27 [info ] Processing codebase\n2025-08-05 03:05:32 [info ] Generated IR for 240 files in 5.20 seconds.\n2025-08-05 03:05:46 [info ] Loaded: 240 files with 14,370 lines of code and 2,383 functions in 19.34s\n2025-08-05 03:05:46 [info ] Running 51 rules\n2025-08-05 03:05:47 [info ] Located 42 findings in 0.77s\n2025-08-05 03:05:47 [info ] Low: 42\n2025-08-05 03:05:47 [info ] Analysis took 0.77s\n2025-08-05 03:05:47 [info ] Scan complete\n","time":"2025-08-05T03:05:49Z"} {"level":"info","msg":"analyzer manager version: 1.20.2","time":"2025-08-05T03:05:17Z"}

JF CLI v2.78.0(Not Working)
{"level":"info","msg":"scanner output: \n 2025-08-05 03:03:00 [info ] Starting scan\n2025-08-05 03:03:00 [info ] Handshake successful\n2025-08-05 03:03:01 [info ] Processing codebase\n2025-08-05 03:03:02 [info ] Side effects only import. No values imported.\n2025-08-05 03:03:02 [info ] Generated IR for 117 files in 1.60 seconds.\n2025-08-05 03:03:04 [info ] Loaded: 117 files with 8,886 lines of code and 893 functions in 3.95s\n2025-08-05 03:03:04 [info ] Running 50 rules\n2025-08-05 03:03:05 [info ] Located 0 findings in 0.99s\n2025-08-05 03:03:05 [info ] Analysis took 0.99s\n2025-08-05 03:03:06 [info ] Scan complete\n","time":"2025-08-05T03:03:07Z"} {"level":"info","msg":"analyzer manager version: 1.21.4","time":"2025-08-05T03:02:56Z"}

Run github/codeql-action/upload-sarif@v3
Uploading code scanning results Processing sarif files: ["jfrog_sast.sarif"] Validating jfrog_sast.sarif Adding fingerprints to SARIF file. See https://docs.github.com/en/enterprise-cloud@latest/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#providing-data-to-track-code-scanning-alerts-across-runs for more information. Error: Invalid SARIF. Missing 'results' array in run.

Reproduction steps
  1. Using this project: https://github.com/atlassian-labs/msteams-jira-server
  2. Run the JFrog SAST workflow from GitHub Action's Workflow Catalog
  3. Modify the version env variable to version 2.77.0 and run the SAST scan which should work
  4. Modify the version env variable to version 2.78.0 or latest and run the SAST scan which should not work
Expected behavior

Both versions of the JF CLI or AnalyzerManager should produce the same sarif file.

JFrog CLI version

2.77.0 and 2.78.0+

Operating system type and version

Ubuntu Linux Runner in GitHub SaaS

JFrog Artifactory version

Ent+ SaaS(Latest Version)

JFrog Xray version

3.120.9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing jf audit --sast --format=sarif with the msteams-jira-server project using CLI 2.77.0 and 2.78.0, then compare the generated SARIF and analyzer-manager output. Verify the fix through the GitHub Actions workflow and confirm that the SARIF run contains a results array accepted by github/codeql-action/upload-sarif@v3.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, go
Domain
ci-cd, cli, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.