jfrog / jfrog/jfrog-cli-security

Improper license classification when performing license auditing

Open
#427 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
13
Forks
50
Avg merge
3d 48m
Merged PRs (30d)
26

Description

Describe the bug

When running jf audit --mvn --licenses --format=json > output.json on my project, I get some dependencies tagged with the wrong licenses.

When looking in the output, I find that two of my dependencies are licenses only under the GPL and GPL classpath exception, when I am expecting to find Apache-2 based on their metadata, see:

Current behavior

Current output file

      {
        "license_key": "GPL-2.0",
        "components": {
          "gav://com.google.api.grpc:proto-google-cloud-storage-v2:2.43.0-beta": {
            "impact_paths": [...]
          },
        "license_key": "Classpath-exception-2.0",
        "components": {
          "gav://com.google.api.grpc:proto-google-cloud-storage-v2:2.43.0-beta": {
            "impact_paths": [...]
          },
Reproduction steps

With a dummy empty project and the following pom.xml:

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>

  <groupId>com.activeviam.activepivot</groupId>
  <artifactId>jfrog_audit</artifactId>
  <version>1.0-SNAPSHOT</version>

  <properties>
    <maven.compiler.source>21</maven.compiler.source>
    <maven.compiler.target>21</maven.compiler.target>
  </properties>

  <dependencies>
    <dependency>
      <groupId>com.google.api.grpc</groupId>
      <artifactId>proto-google-cloud-storage-v2</artifactId>
      <version>2.43.0-beta</version>
    </dependency>

    <dependency>
      <groupId>org.eclipse.jetty.ee10.websocket</groupId>
      <artifactId>jetty-ee10-websocket-servlet</artifactId>
      <version>12.0.15</version>
    </dependency>
  </dependencies>
</project>
Expected behavior

I would expect a section in the output file with the Apache 2 license information, and no GPL licenses:

      {
        "license_key": "Apache-2.0",
        "components": {
          "gav://com.google.api.grpc:proto-google-cloud-storage-v2:2.43.0-beta": {
            "impact_paths": [...]
          }
JFrog CLI version

jf version 2.74.0

Operating system type and version

Ubuntu 24.04.2

JFrog Artifactory version

No response

JFrog Xray version

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the jf audit --mvn --licenses --format=json entry point and reproduce the issue using the provided pom.xml and dependency versions. Compare the generated license sections with the Maven metadata for both dependencies; done means the output classifies them as Apache-2.0 and contains no GPL licenses.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.