jfrog / jfrog/jfrog-cli-security
jf audit: SARIF format is missing most of the fields provided by the JSON format
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 13
- Forks
- 50
- Avg merge
- 3d 48m
- Merged PRs (30d)
- 26
Description
Describe the bug
SARIF format is not on-par with the JSON format.
Current behavior
SARIF format is missing most of the JSON format information:
- No license (FOSS) information at all
- CVSS Vector
- Impacted paths
- In-case of a multi-maven project, the uri is "pom.xml" (no module prefix) with startLine, startColumn and endLine set to 0.
- Fixed versions
- All of the extended information (from the R&D enrichment)
- Haven't verified the contextual analysis, but my guess is, it is also missing
- References
Note:
- I validated the sarif output and apparently it isn't following the SARIF format properly as well, see https://sarifweb.azurewebsites.net/Validation to validate a SARIF file
Reproduction steps
- Perform a scan with the JSON format
- Perform a scan with the SARIF format
- Compare the 2
Expected behavior
SARIF format is on-par with the JSON format in term of information provided.
JFrog CLI version
2.42.1
Operating system type and version
Docker
JFrog Artifactory version
No response
JFrog Xray version
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with JFrog CLI 2.42.1, comparing JSON and SARIF scan output and validating the SARIF file with the linked validator. Trace the SARIF output entry point and its handling of licenses, CVSS, paths, fixed versions, enrichment, contextual analysis, and references; done means the output is comparable in information and passes SARIF validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100