jfrog / jfrog/jfrog-cli-security

Build scan shows passing when xray fails

Open
#328 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
13
Forks
50
Avg merge
3d 48m
Merged PRs (30d)
26

Description

[Info] Deploying build info...
[Info] Build info successfully deployed. Browse it in Artifactory under 
****
Scanning build for vulnerabilities
[Info] Triggered Xray build scan... The scan may take a few minutes.
[Info] Xray scan completed.
{
  "summary": {
    "total_alerts": 0,
    "fail_build": false,
    "message": "Build orca-armory number 0.0.1-dev.121.65a1d0f was scanned by Xray and passed with no Alerts",
    "more_details_url": "***"
  },
  "alerts": [],
  "licenses": [
    {
      "name": "Unknown",
      "full_name": "Unknown license",
      "components": [
        "build://orca-armory:0.0.1-dev.121.65a1d0f"
      ]
    }
  ]
}

However, looking at x-ray it shows that the build has a number of issues. Workflow steps (with most things masked):

 JFROG_ARGS: --url *** --user *** --password ***
docker build ***/$BASE_PROJECT:$BUILD_NUMBER
jfrog rt docker-push ***/$BASE_PROJECT:$BUILD_NUMBER docker-local --build-name=$BASE_PROJECT-armory --build-number=$BUILD_NUMBER $JFROG_ARGS
  jfrog rt build-publish $BASE_PROJECT $BUILD_NUMBER $JFROG_ARGS
  jfrog rt build-scan  $BASE_PROJECT-armory $BUILD_NUMBER $JFROG_ARGS

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the shown workflow, especially the jfrog rt build-publish and jfrog rt build-scan commands, and compare their build names and numbers with the Xray result. Trace the build-scan command's result handling; done means the CLI's reported pass/fail status matches the issues shown by Xray.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
cli, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.