jfrog / jfrog/frogbot

Does the PR scan open new PRs?

Open
#619 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Go
Stars
372
Forks
107
Avg merge
2d 20h
Merged PRs (30d)
5

Description

I noticed the following setting in the template frogbot-scan-pull-request.yml file:

          # [Optional, Default: "FALSE"]
          # If TRUE, Frogbot creates a single pull request with all the fixes.
          # If false, Frogbot creates a separate pull request for each fix.
          # JF_GIT_AGGREGATE_FIXES: "FALSE"

https://github.com/jfrog/documentation/blob/77008ab7c9402ea1a7eb6b99c016074cd1ada5fe/jfrog-applications/frogbot/templates/github-actions/frogbot-scan-pull-request.yml#L116-L119

This implies it will create PRs to resolve issues detected by the PR scan. Is this actually the case? Shouldn't this only be true for the repo scan?

Also, since the default value is already "FALSE", perhaps # JF_GIT_AGGREGATE_FIXES: "FALSE" should be changed to # JF_GIT_AGGREGATE_FIXES: "TRUE". frogbot-scan-repository.yml would also need to be updated with this change.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the referenced frogbot-scan-pull-request.yml template and compare its JF_GIT_AGGREGATE_FIXES setting with frogbot-scan-repository.yml. Verify whether PR scans create pull requests for detected fixes, then determine the expected default and update both templates if needed. Done means the behavior and template configuration are consistent and clearly represented.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.