jfrog / jfrog/artifactory-client-java

doUploadAndExplode doesn't invoke Listener

Open
#395 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
331
Forks
163
Avg merge
20h 9m
Merged PRs (30d)
1

Description

Describe the bug
listener is ignored if uploaded with doUploadAndExplode

To Reproduce
this logs:

var uploaded = artifactory
                    .repository(repositoryName)
                    .upload(targetPath, file)
                    .withListener((bytesRead, totalBytes) -> {
                        log.debug("Artifactory ({} / {})", bytesRead, totalBytes);
                    })
                    .doUpload();

but this doesn't:

var uploaded = artifactory
                    .repository(repositoryName)
                    .upload(targetPath, file)
                    .withListener((bytesRead, totalBytes) -> {
                        log.debug("Artifactory ({} / {})", bytesRead, totalBytes);
                    })
                    .doUploadAndExplode(true);

also it would be more consistent if both methods would have the same return type

Expected behavior
listener should be invoked also with the explode feature.

Versions

  • Artifactory Java Client version: 2.19.1
  • Operating system: WIN11pro
  • Artifactory Version: Enterprise Plus 7.77.14 rev

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the upload(...).withListener(...).doUploadAndExplode(true) entry point and compare its listener handling with doUpload(). Verify that the listener is invoked during the explode flow, and check whether the two methods' return types can be made consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.